-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare observations for snow DA updates to the ensemble members #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a draft, corresponding workflow PR? I am not particularly thrilled about these additional variable names and would prefer to come up with a way that is more consistent with other observation types.
EDIT: Never mind, I see you have it linked above. I will comment there.
…/GDASApp into feature/prepsnowobs_ens
* upstream/develop: Get SOCA vrfy job working on Hera again (#1045) Get test data from a staged location on supported HPC Part Deux (#1052) Prepare observations for snow DA updates to the ensemble members (#998) Save basic stats in csv at each cycle (#1040) Fix bug for datetime in GHRSST Ioda Converter (#1027)
@jiaruidong2017 I'm going to revert this PR as I think it is holding up other workflow PRs. We can re-merge it when the workflow is ready... |
This PR updates several configures to prepare observations for snow DA updates to the ensemble members. Because the snow observations are fetched from the COM_OBS in the gdas deterministic analysis and are saved into the COM_OBS in the enkfgdas analysis for the enkfgdas run, we have to define two different COM_OBS directories (COMIN_OBS vs COMOUT_OBS) and two obs basename heads (OPREFIX_IN vs OPREFIX_OUT) to identify the enkf analysis from the gdas deterministic analysis.
This PR will contribute to NOAA-EMC/global-workflow#2416.